This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Change the visibility of InputRef::full_slice() from pub(crate) to public#960
Merged
Conversation
…b, enabling access to the complete raw input slice from within the imperative-style custom() method
zesterer
reviewed
Feb 14, 2026
|
|
||
| /// Get full slice of raw input. | ||
| /// | ||
| /// Note we have to make sure our index of full slice land in the correct boundary of utf8 character if using utf8 input. |
Owner
There was a problem hiding this comment.
I'm not sure that I understand what this note is trying to say, could you clarify?
Contributor
Author
There was a problem hiding this comment.
For example, if the slice of raw input is &str,
let s: &str = "你好"; // for utf8 character, non ascii character
// OK
let a = &s[0..3];
println!("{}", a);
// panic since 1 is not the right byte boundary of utf8 char <--------------
let a = &s[1..3];
println!("{}", a);
Owner
There was a problem hiding this comment.
There is no particular notion of 'boundaries' built into SliceInput, that's purely a function of &str. I don't think this is worth mentioning in this doc comment.
I am not sure what 'our index of full slice' refers to in the comment either: the method has no parameters?
Contributor
Author
There was a problem hiding this comment.
You are right. I have removed the unclear and unnecessary lines in the comments.
…blic: make the doc clear
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the visibility of InputRef::full_slice() from pub(crate) to pub, enabling access to the complete raw input slice from within the imperative-style custom() method